Re: [PATCH] test-lint-duplicates: check numbering in contrib/remote-helpers

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 3, 2013, 04:00 UTC
Message-ID: <CAPig+cTCTbbA+sqJSc00OOhyxwQ-jPJ3SSGF=Hi8+P+OG=wEkQ@mail.gmail.com>
In-Reply-To: <201304021853.48643.tboegi@web.de>

On Tue, Apr 2, 2013 at 12:53 PM, Torsten Bögershausen <tboegi@web.de> wrote:

> Running make inside contrib/remote-helpers failes in "test-lint-duplicates"

s/failes/fails/

Show 21 quoted lines

> This was because the regexp to check for duplicate numbers strips everything
> after the first "-" in the filename, including the prefix.
>
> As a result, 2 pathnames like
> "xxxx/contrib/remote-helpers/test-bzr.sh" and
> "xxxx/contrib/remote-helpers/test-hg-bidi.sh"
>
> are both converted into
> "xxxx/contrib/remote", and reported as duplicate.
>
> Improve the regexp:
> Remove everything after tNNNN- (where X stand for a digit)
>
> Rename the tests in contrib/remote-helpers into
> t5810-test-bzr.sh,
> t5820-test-hg-bidi.sh,
> t5821-test-hg-hg-git.sh,
> t5830-test-hg.sh
>
> Feed the numbers used in contrib/remote-helpers into t/Makefile
> and check that numbering is unique across both directories