Re: [PATCH v6 1/2] worktrees: add find_shared_symref
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Aug 10, 2015, 22:30 UTC
- Message-ID
- <CAPig+cTBLx2Q0n2ZcA-QgwNQMHZm9G45ThHbGc+Orkz-6c5cUg@mail.gmail.com>
- In-Reply-To
- <1439229165-25773-1-git-send-email-dturner@twopensource.com>
On Mon, Aug 10, 2015 at 1:52 PM, David Turner <dturner@twopensource.com> wrote:
> worktrees: add find_shared_symref
s/worktrees/branch/ perhaps?
Show 12 quoted lines
> Add a new function, find_shared_symref, which contains the heart of > die_if_checked_out, but works for any symref, not just HEAD. Refactor > die_if_checked_out to use the same infrastructure as > find_shared_symref. > > Soon, we will use find_shared_symref to protect notes merges in > worktrees. > > Signed-off-by: David Turner <dturner@twopensource.com> > --- > This version addresses Eric Sunshine's comments on v5. It fixes an error > message and cleans up the code.
All issues identified in previous versions seem to have been addressed, and nothing else pops out at me. Thanks.