Re: [PATCH v2 0/7] nd/worktree-move reboot

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 4, 2018, 05:36 UTC
Message-ID: <CAPig+cT88ZsD4=U0NUPM2=sv43gxFEf7ivxu1zMHr0gsMGdTmg@mail.gmail.com>
In-Reply-To: <20180212094940.23834-1-pclouds@gmail.com>

On Mon, Feb 12, 2018 at 4:49 AM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

> v2 basically fixes lots of comments from Eric (many thanks!): memory
> leak, typos, document updates, tests, corner case fixes.
> Interdiff:

Thanks, I finally got around to doing a full re-read of the entire series. v2 appears to address all issues raised in my review[1] of v1.

I did find a few minor issues in tests newly added and revised in v2. However, since v2 already migrated to 'next', rather than pointing out the issues as review comments, I instead sent a patch[2] (built atop nd/worktree-move-reboot) to address them.

[1]: https://public-inbox.org/git/20180124095357.19645-1-pclouds@gmail.com/ [2]: https://public-inbox.org/git/20180304052647.26614-1-sunshine@sunshineco.com/