Re: [PATCH 0/1 v2] Replace SID with domain/username on Windows

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 31, 2023, 04:08 UTC
Message-ID: <CAPig+cT4jy4MkyGxtSOZj6U3vUxLaRa-4wr7PON-EebAjT8pwQ@mail.gmail.com>
In-Reply-To: <20231229120319.3797-1-soekkle@freenet.de>

On Fri, Dec 29, 2023 at 7:03 AM Sören Krecker <soekkle@freenet.de> wrote:

Show 27 quoted lines

> Improve error message on windows systems, if owner of reposotory and current user are not equal.
>
> Old Message:
> '''
> fatal: detected dubious ownership in repository at 'C:/Users/test/source/repos/git'
> 'C:/Users/test/source/repos/git' is owned by:
>         'S-1-5-21-571067702-4104414259-3379520149-500'
> but the current user is:
>         'S-1-5-21-571067702-4104414259-3379520149-1001'
> To add an exception for this directory, call:
>
>         git config --global --add safe.directory C:/Users/test/source/repos/git
> '''
>
> New Massage:
> '''
> fatal: detected dubious ownership in repository at 'C:/Users/test/source/repos/git'
> 'C:/Users/soren/source/repos/git' is owned by:
>         'DESKTOP-L78JVA6/Administrator'
> but the current user is:
>         'DESKTOP-L78JVA6/test'
> To add an exception for this directory, call:
>
>         git config --global --add safe.directory C:/Users/test/source/repos/git
> '''
>
> I hope that I have succeeded in addressing all the points raised.

Thanks, this explanation does an excellent job of helping reviewers understand why the patch is desirable.

It's also important that people digging through the project history in the future also understand the reason for this change, so it's very valuable for the explanation to be part of the commit message of the patch itself, not just in the cover letter (which doesn't become part of the permanent project history). Therefore, can you reroll once again, placing this explanation in the commit message of the patch itself? Doing so should help the patch get accepted into the project.

That's as much as I can add. Hopefully, one or more Windows folks will chime in regarding the actual patch content (whether it's acceptable as-is or needs some tweaks).

Thanks.