Re: [PATCH] test_cmp: diagnose incorrect arguments

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 9, 2020, 08:49 UTC
Message-ID: <CAPig+cT3Mwy6gJE3=5P78xwmFSp+gJYazboZtrkpFy7v8X7K2A@mail.gmail.com>
In-Reply-To: <20200809083227.GA11219@konoha>

On Sun, Aug 9, 2020 at 4:32 AM Shourya Shukla <shouryashukla.oo@gmail.com> wrote:

Show 6 quoted lines

> > +       test -e "$1" || BUG "test_cmp 'expect' file missing"
> > +       test -e "$2" || BUG "test_cmp 'actual' file missing"
>
> I reckon we could be just a little bit more precise here by bugging out
> with the exact filename which is missing instead of 'expect' or 'actual'
> so that the user has more idea as to what happened. What do you think?

Good idea. I'm planning on re-rolling anyhow since Junio pointed out privately that some callers use "-" (meaning standard input) as one of the arguments to test_cmp(), so that case ought to be taken into account, as well.

Show 8 quoted lines

> BTW, I looked up the 'test_i18ncmp' function as well and if we have
> this small loophole you mentioned above, I think maybe we could make a
> similar fix for it too. What I mean is that in case of absence of the
> required locale, it should error out kind of like what we did above
>
>   BUG "locale missing"
>
> so that the user it is clear to the user what was the failure point.

Sorry, I'm not really sure what you are suggesting, but I'm guessing that you're misunderstanding of the purpose of test_i18ncmp:

    test_i18ncmp () {
        ! test_have_prereq C_LOCALE_OUTPUT || test_cmp "$@"
    }

which says that test_cmp() should only be called if the current locale is "C"; in all other cases, we specifically do not want test_cmp() to be called and instead simply pretend that the test passed.