git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] git-format-patch.txt: don't show -s as shorthand for multiple options

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 4, 2016, 22:44 UTC
Message-ID
<CAPig+cT2w_t68w5qr-bYxrgOdXcO=RhuazCnoHuF4J7n+AQi5A@mail.gmail.com>
In-Reply-To
<CAPig+cR1mmx+2D7U8ejx8HTWbFtxbmi-85D0hgm9J48bkai6CA@mail.gmail.com>
On Mon, Apr 4, 2016 at 6:38 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 16 quoted lines
> On Mon, Apr 4, 2016 at 4:07 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Eric Sunshine <sunshine@sunshineco.com> writes:
>>>> Given that the ifndef/endif block immediately before this part is
>>>> also about excluding -p/-u/--patch when formatting the documentation
>>>> for format-patch, perhaps the attached may be a smaller equivalent?
>>>
>>> Perhaps. I kept self-contained to make it easier to add new options
>>> between the two if need be, but I don't feel strongly about it.
>>
>> I don't either, but the reason why I thought it would make sense to
>> have them in the same block is because hiding --no-patch and --patch
>> are about the same theme: format-patch is about presenting the diff,
>> and neither disabling diff output nor explicitly asking for diff
>> output makes sense.
>
> That's reasonable. Should I re-roll, or would you like to amend it locally?

Okay, I just pulled upon seeing "What's Cooking" and see that you amended it locally. Thanks.

Previous: Eric SunshineNext: Jacob Keller
Message 7 of 8 in “git-format-patch.txt: don't show -s as shorthand for multiple options”
  1. git-format-patch.txt: don't show -s as shorthand for multiple optionsEric Sunshine, Mar 27, 2016
  2. Eric SunshineApr 4, 2016
  3. Junio C HamanoApr 4, 2016
  4. Eric SunshineApr 4, 2016
  5. Junio C HamanoApr 4, 2016
  6. Eric SunshineApr 4, 2016
  7. Eric SunshineApr 4, 2016
  8. Jacob KellerApr 8, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.