Re: [PATCH v3 5/6] for-each-ref: introduce %(color:...) for color

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 17, 2013, 00:04 UTC
Message-ID: <CAPig+cT2LYTRwVfkNEdH4U+eJ4STcRd3tKYMDekb239qLw=zvA@mail.gmail.com>
In-Reply-To: <1384513148-22633-6-git-send-email-artagnon@gmail.com>

On Fri, Nov 15, 2013 at 5:59 AM, Ramkumar Ramachandra <artagnon@gmail.com> wrote:

Show 23 quoted lines

> Enhance 'git for-each-ref' with color formatting options.  You can now
> use the following format in for-each-ref:
>
>   %(color:green)%(refname:short)%(color:reset)
>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
>  Documentation/git-for-each-ref.txt |  4 ++++
>  builtin/for-each-ref.c             | 11 +++++++++--
>  t/t6300-for-each-ref.sh            | 14 ++++++++++++++
>  3 files changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/git-for-each-ref.txt b/Documentation/git-for-each-ref.txt
> index c9b192e..2f3ac22 100644
> --- a/Documentation/git-for-each-ref.txt
> +++ b/Documentation/git-for-each-ref.txt
> @@ -101,6 +101,10 @@ HEAD::
>         Used to indicate the currently checked out branch.  Is '*' if
>         HEAD points to the current ref, and ' ' otherwise.
>
> +color::
> +       Used to change color of output.  Followed by `:<colorname>`,
> +       where names are described in `color.branch.*`.

"Used to" sounds past tense. Perhaps:

    color:<colorname>::
      Change output color to `<colorname>`, where...

>  In addition to the above, for commit and tag objects, the header
>  field names (`tree`, `parent`, `object`, `type`, and `tag`) can
>  be used to specify the value in the header field.