Re: [PATCH v3 2/2] completion: add support for completing email aliases

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Nov 17, 2015, 08:10 UTC
Message-ID: <CAPig+cT0VmKQm5x9Q2QUyLr=-e0VN53d-O5Cw2CPB=gYz6SUQA@mail.gmail.com>
In-Reply-To: <1447720166-9941-2-git-send-email-jacob.e.keller@intel.com>

On Mon, Nov 16, 2015 at 7:29 PM, Jacob Keller <jacob.e.keller@intel.com> wrote:

> Using the new --dump-alias-names option from git-send-email, add completion

s/dump-alias-names/dump-aliases/

> for --to, --cc, and --bcc with the available configured aliases.

"--from" is missing from this list.

Show 44 quoted lines

> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> ---
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> @@ -1709,8 +1710,25 @@ _git_reflog ()
>  __git_send_email_confirm_options="always never auto cc compose"
>  __git_send_email_suppresscc_options="author self cc bodycc sob cccmd body all"
>
> +__git_get_email_aliases ()
> +{
> +       git --git-dir="$(__gitdir)" send-email --dump-aliases 2>/dev/null | while read alias expansion
> +       do
> +               echo $alias
> +       done
> +}
> +
>  _git_send_email ()
>  {
> +       case "$prev" in
> +       --to|--cc|--bcc|--from)
> +               __gitcomp "
> +               $(__git_get_email_aliases)
> +               " "" ""
> +               return
> +               ;;
> +       esac
> +
>         case "$cur" in
>         --confirm=*)
>                 __gitcomp "
> @@ -1735,6 +1753,12 @@ _git_send_email ()
>                         " "" "${cur##--thread=}"
>                 return
>                 ;;
> +       --to=*|--cc=*|--bcc=*|--from=*)
> +               __gitcomp "
> +               $(__git_get_email_aliases)
> +               " "" "${cur#--*=}"
> +               return
> +               ;;
>         --*)
>                 __gitcomp "--annotate --bcc --cc --cc-cmd --chain-reply-to
>                         --compose --confirm= --dry-run --envelope-sender
> --
> 2.6.3.491.g3e3f6ce