Re: [PATCH v3] notes: teach the -e option to edit messages in editor

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 21, 2024, 18:28 UTC
Message-ID: <CAPig+cSw_F97nBzO3Z7t2Zrv5TZwGnYiQLhpq2iKgLfxhhxvfQ@mail.gmail.com>
In-Reply-To: <ZxaG67wuvjOXc5kr@nand.local>

On Mon, Oct 21, 2024 at 12:53 PM Taylor Blau <me@ttaylorr.com> wrote:

Show 11 quoted lines

> On Mon, Oct 21, 2024 at 02:38:15PM +0000, Samuel Adekunle Abraham via GitGitGadget wrote:
> > +     MSG="Edited notes message" git notes add -m "Initial notes message" -e &&
> > +     echo "Edited notes message" >expect &&
>
> Very nice use of the fake_editor script here.
>
> It is a little cumbersome to repeat the same message in MSG= and when
> populating the 'expect' file. Perhaps instead this could be written as:
>
>     echo "edited notes message" >expect &&
>     MSG="$(cat expect)" git notes -add -m "initial" -e

This suggested rewrite feels unusually roundabout and increases cognitive load for readers who now have to trace the message flow from script to file and back into script, and to consider how the loss of trailing newline caused by use of $(...) impacts the behavior. It also wastes a subprocess (which can be expensive on some platforms, such as Windows). If we're really concerned about this minor duplication of the message, we can instead do this:

    msg="edited notes message" &&
    echo "$msg" >expect &&
    MSG="$msg" git notes -add -m "initial" -e