Re: ab/run-command + em/missing-pager (was: What's cooking in git.git (Nov 2021, #07; Mon, 29))
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Nov 30, 2021, 22:09 UTC
- Message-ID
- <CAPig+cSvFgJTiq8pXrWy_7ukQwE1y9ZGwMgKmyjWuQHdNGxiDQ@mail.gmail.com>
- In-Reply-To
- <211130.86k0gpcpy2.gmgdl@evledraar.gmail.com>
On Tue, Nov 30, 2021 at 4:07 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 8 quoted lines
> On Mon, Nov 29 2021, Junio C Hamano wrote: > > * ab/run-command (2021-11-25) 9 commits > > - worktree: stop being overly intimate with run_command() internals > > I think the only outstanding thing for this topic is Eric's [1] comment > (on his own code). I think that variable shadowing is OK. > > 1. https://lore.kernel.org/git/CAPig+cRi6SeuV7k_+9JCcnf79daLZp5B=EyHK-KxC1VGN0B4ig@mail.gmail.com/
I'm also fine with the variable shadowing and don't consider it an outstanding issue with the topic (it was just a minor observation in case anyone complained). I didn't see anything else worth commenting on in the remainder of the series.