Re: Solaris sed

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 13, 2025, 20:23 UTC
Message-ID: <CAPig+cSu7+fxveULiB1vDbcy6Cnia_5isVVy+RCO+HGAyr8uvg@mail.gmail.com>
In-Reply-To: <5895400.DvuYhMxLoT@cayenne>

On Fri, Jun 13, 2025 at 4:15 PM Jean-Noël AVILA <jn.avila@free.fr> wrote:

> Would it be possible to set up some kind of CI to check for compatibility with
> such systems. This is the second time I introduced regressions without even
> knowing it, and it would be really great to catch them before borking a
> release process.

Had this been in a test script, it would have been caught by t/check-non-portable-shell.sh. We may want to apply the check to build-related scripts, as well. For instance, it would have caught the -E problem:

    % ./t/check-non-portable-shell.pl generate-*.sh
    generate-configlist.sh:16: error: sed option not portable (use
only -n, -e, -f): sed -E '
    %

You can, of course, run check-non-portable-shell.pl manually after editing a script, but perhaps this check could be enabled by a (hopefully) minor tweak to the main Git Makefile?