Re: [PATCH v2 2/3] worktree: delete dead code

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 18, 2018, 22:51 UTC
Message-ID: <CAPig+cSrsc4MhFf_h4b0Rc=hsxux4p=pkQkYVfs_zTR3u7sH-A@mail.gmail.com>
In-Reply-To: <20180315164412.14697-3-pclouds@gmail.com>

On Thu, Mar 15, 2018 at 12:44 PM, Nguyễn Thái Ngọc Duy <pclouds@gmail.com> wrote:

Show 5 quoted lines

> This "link" was a feature in early iterations of multiple worktree
> functionality for some reason it was dropped [1]. Since nobody creates
> this "link", there's no need to check it.
>
> This is mostly used to let the user moves a worktree manually [2]. If

s/moves/move/

(Not worth a re-roll; perhaps Junio can tweak this when queuing.)

Show 13 quoted lines

> you move a worktree within the same file system, this hard link count
> lets us know the worktree is still there even if we don't know where it
> is.
>
> We support 'worktree move' now and don't need this anymore.
>
> [1] last appearance in v4 message-id:
>     1393675983-3232-25-git-send-email-pclouds@gmail.com
>     and the reason in v5 was "revisit later", message-id:
>     1394246900-31535-1-git-send-email-pclouds@gmail.com
> [2] 23af91d102 (prune: strategies for linked checkouts - 2014-11-30)
>
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>