Re: [PATCH 0/2] Avoid rewriting "packed-refs" unnecessarily

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Oct 25, 2017, 20:10 UTC
Message-ID: <CAPig+cSrjiyGUm0n5dvowjNYZMSGvb+SZJ=haTsxXi9NcThA7A@mail.gmail.com>
In-Reply-To: <cover.1508924577.git.mhagger@alum.mit.edu>

On Wed, Oct 25, 2017 at 5:53 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:

Show 10 quoted lines

> Since commit dc39e09942 (files_ref_store: use a transaction to update
> packed refs, 2017-09-08), we've been rewriting the `packed-refs` file
> unnecessarily when deleting a loose reference that has no packed
> counterpart. Add some tests demonstrating this problem, then fix it by
> teaching `files_backend` to see whether any references being deleted
> have packed versions, and if not, skipping the packed_refs
> transaction.
>
> This is a mild regression since 2.14, which avoided rewriting the
> `packed-refs` file in these cases [...]

Should the above information (that this fixes a regression) be mentioned in the commit message of at least one of the patches (probably 2/2)? Without such context, it may not be clear to someone later reading those commit message -- someone who wasn't following this email discussion -- that this behavior had been lost and is now being restored.