Re: parse-options does not recognize "unspecified" behavior

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 17, 2016, 05:32 UTC
Message-ID: <CAPig+cSmQpt3u+1PPFD6CP9TF58R6NR=KCgC1dik9U=deaeCkA@mail.gmail.com>
In-Reply-To: <20160317014310.GA12830@sigill.intra.peff.net>

On Wed, Mar 16, 2016 at 9:43 PM, Jeff King <peff@peff.net> wrote:

Show 6 quoted lines

> Arguably cmd_commit() should be using OPT_BOOL instead of OPT__VERBOSE,
> as there is no such thing as "verbose > 1" here. But I don't think there
> is any real user-facing consequence of that (however, given Eric's
> suggestion, I suspect it would make Pranit's problem just go away, as it
> assigns rather than increments; IOW, it does the thing Eric was
> suggestion OPT__VERBOSE to do).

Actually, Pranit's previous version of the patch did treat verbosity as a boolean, but then SZEDER pointed out this bit from git-commit.txt:

    --verbose::
        ...
        If specified twice, show in addition the unified diff between
        what would be committed and the worktree files, i.e. the unstaged
        changes to tracked files.

which is what led us to the current discussion about wanting an "unspecified" value for OPT__VERBOSE.