Re: [PATCH 1/2] for-each-repo: optionally keep going on an error
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 17, 2024, 08:36 UTC
- Message-ID
- <CAPig+cSjoGe7Eeynz=jGSaNYWXQ-VkvWv7mv1NDeCXPFEtdqOA@mail.gmail.com>
- In-Reply-To
- <6721e3ada5d125bd6c33561c694acb986b17b38f.1713342535.git.gitgitgadget@gmail.com>
On Wed, Apr 17, 2024 at 4:29 AM Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com> wrote:
Show 8 quoted lines
> In https://github.com/microsoft/git/issues/623, it was reported that > the regularly scheduled maintenance stops if one repo in the middle of > the list was found to be missing. > > This is undesirable, and points out a gap in the design of `git > for-each-repo`: We need a mode where that command does not stop on an > error, but continues to try the running the specified command with the > other repositories.
s/try the running/try running/
Show 11 quoted lines
> Imitating the `--keep-going` option of GNU make, this commit teaches
> `for-each-repo` the same trick: to continue with the operation on all
> the remaining repositories in case there was a problem with one
> repository, still setting the exit code to indicate an error occurred.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
> ---
> diff --git a/builtin/for-each-repo.c b/builtin/for-each-repo.c
> @@ -39,6 +40,8 @@ int cmd_for_each_repo(int argc, const char **argv, const char *prefix)
> + OPT_BOOL(0, "keep-going", &keep_going,
> + N_("stop at the first repository where the operation failed")),Isn't this help string opposite the intended meaning? Taking a hint from GNU "make --help", should it instead by something like:
N_("keep going even if command fails in a repository")),