Re: [PATCH v2 1/2] t: don't spuriously close and reopen quotes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 6, 2020, 20:26 UTC
Message-ID: <CAPig+cSjHg2-WYqdkZAS0ye1goj_=5RN3mdjt0-4kSBqNm6WLg@mail.gmail.com>
In-Reply-To: <c60416a111bada9624b8b64235ac5c4dd3dedac4.1596742823.git.martin.agren@gmail.com>

On Thu, Aug 6, 2020 at 4:09 PM Martin Ågren <martin.agren@gmail.com> wrote:

Show 6 quoted lines

> diff --git a/t/t4200-rerere.sh b/t/t4200-rerere.sh
> @@ -364,7 +364,7 @@ test_expect_success 'set up an unresolved merge' '
>         fifth=$(git rev-parse fifth) &&
> -       echo "$fifth            branch 'fifth' of ." |
> +       echo "$fifth            branch fifth of ." |
>         git fmt-merge-msg >msg &&

This one is a bit weird. It really seems as if the intent was to quote the word "fifth" in the merge message, so dropping the quotes altogether seems wrong. However, the file 'msg' is never even consulted in this test (or any other test), so is this just "dead code" (including the leading 'fifth=' assignment which also is otherwise unused outside the 'echo')?

Show 6 quoted lines

> diff --git a/t/t5510-fetch.sh b/t/t5510-fetch.sh
> @@ -213,7 +213,7 @@ test_expect_success 'fetch tags when there is no tags' '
>  test_expect_success 'fetch following tags' '
>         cd "$D" &&
> -       git tag -a -m 'annotated' anno HEAD &&
> +       git tag -a -m "annotated" anno HEAD &&

There are a fair number of these quoted single-token arguments containing no special characters which don't actually need to be quoted at all, so an alternative would be simply to drop the quotes altogether, making the commands less syntactically noisy. However, that might be outside the intended scope of this change.