Re: [PATCH v1] config: Add hashtable for config parsing & retrival

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 10, 2014, 11:51 UTC
Message-ID: <CAPig+cSjAxVN8GLit-nZ9sUxmMvC1KcSFMJayJSarQEcqyYvjw@mail.gmail.com>
In-Reply-To: <vpqmwdmtb2o.fsf@anie.imag.fr>

On Mon, Jun 9, 2014 at 10:24 AM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 15 quoted lines

> Tanay Abhra <tanayabh@gmail.com> writes:
>> +struct config_cache_entry {
>> +     struct hashmap_entry ent;
>> +     char *key;
>> +     struct string_list *value_list;
>> +};
>
> I guess this crossed Eric's remark about the fact that this is a
> pointer.
>
>> +static void config_cache_free(void)
>
> I didn't look closely enough to make sure there were no memory leak
> remaining, but did you check with valgrind --leak-check that it is the
> case in practice?

It does leak the config_cache_entry::value_list member which was xcalloc()'d in config_cache_set_value(). (I didn't mention it in my reviews because I was expecting 'value_list' to be changed to a plain structure rather than a pointer to a structure.)