git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/3] t6050: redirect expected error output to /dev/null

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Mar 28, 2019, 18:41 UTC
Message-ID
<CAPig+cSj5WZeGy4nwgafGtBbz7y921M8H57eFbBXwRy2Bm-C+g@mail.gmail.com>
In-Reply-To
<20190328171722.9753-2-chriscool@tuxfamily.org>

On Thu, Mar 28, 2019 at 1:17 PM Christian Couder <christian.couder@gmail.com> wrote:

Show 9 quoted lines
> Otherwise the error from `git rev-parse` is uselessly
> polluting the debug output.
>
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
> diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh
> @@ -40,7 +40,7 @@ commit_peeling_shows_parents ()
> -    test_must_fail git rev-parse --verify $_commit^$_parent_number
> +    test_must_fail git rev-parse --verify $_commit^$_parent_number 2>/dev/null

When I'm debugging test failures, I find it very helpful to see that a command which was expected to fail did indeed fail with the expected error message, so I don't consider such a message as "uselessly polluting the debug output". Consequently, I'm rather negative on this change.

Previous: Christian CouderNext: Ævar Arnfjörð Bjarmason
Message 3 of 6 in “t6050: use test_line_count instead of wc -l”
  1. 1/3 t6050: use test_line_count instead of wc -lChristian Couder, Mar 28, 2019
  2. 2/3 t6050: redirect expected error output to /dev/nullChristian Couder, Mar 28, 2019
  3. Eric SunshineMar 28, 2019
  4. Ævar Arnfjörð BjarmasonMar 28, 2019
  5. 3/3 replace: fix --graft when passing a tagChristian Couder, Mar 28, 2019
  6. Taylor BlauMar 28, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.