git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: silence git-gc if --quiet is given

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 6, 2020, 16:09 UTC
Message-ID
<CAPig+cSi5xe_FSzr7Z3D6+f1WxsbPthQnWcE1FrLyhrmi4TCGg@mail.gmail.com>
In-Reply-To
<20200506140138.650455-1-abhishekkumar8222@gmail.com>

On Wed, May 6, 2020 at 10:03 AM Abhishek Kumar <abhishekkumar8222@gmail.com> wrote:

> As reported by Perrick [1], commit does not propagate quiet behavior to
> gc if present. While we are at it, convert argv_gc_auto to struct argv_array.
>
> [1]: https://lore.kernel.org/git/20200506094327.GC31637@rillettes/

According to the source you cite, this sort of issue has come up before in a different context (git-fetch). Do we know if there are other commands which invoke git-gc which might also suffer the same issue? It would be nice for the commit message to say something about this... for instance, that git-commit is the final command which needs this fix or, if not, which additional commands are likely to need the same treatment.

> Reported-by: Pierrick Gaudry <pierrick.gaudry@loria.fr>
> Signed-off-by: Abhishek Kumar <abhishekkumar8222@gmail.com>
Previous: Abhishek KumarNext: Junio C Hamano
Message 2 of 3 in “commit: silence git-gc if --quiet is given”
  1. commit: silence git-gc if --quiet is givenAbhishek Kumar, May 6, 2020
  2. Eric SunshineMay 6, 2020
  3. Junio C HamanoMay 6, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.