git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Perf lib sanity tests fail on OSX

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Dec 16, 2020, 07:44 UTC
Message-ID
<CAPig+cSh0L3RniJpEs3oddkzPGUyw5Ud39SAbYFoxwtBowLiaQ@mail.gmail.com>
In-Reply-To
<fde32488-97e7-55f3-86d5-25f525492844@gmail.com>

On Tue, Dec 15, 2020 at 9:19 PM Philippe Blain <levraiphilippeblain@gmail.com> wrote:

Show 15 quoted lines
> Le 2020-12-15 à 14:08, Sangeeta a écrit :
> > The performance test, p0000-perf-lib-sanity.sh[1], is failing on my
> > local OSX machine due to an error in the test_export of the foo
> > variable. [...]
>
> It is not the export per se that fails (that would be very bad news
> indeed), it is the shell magic in the 'test_run_perf_' function in
> 'perf-lib.sh' that uses a non-portable sed(1) invocation:
>
> As you might already know, since macOS has some BSD background/ancestry,
> most POSIX utilities are closer to the OpenBSD/FreeBSD versions than to
> their GNU/Linux counterparts.
>
> I do not know sed syntax enough to fix the invocation to make it
> portable (nor do I know if it's possible).

A patch fixing the problem (correctly diagnosed by Philippe as non-portable `sed` usage) has been posted[1].

[1]: https://lore.kernel.org/git/20201216073907.62591-1-sunshine@sunshineco.com/
Previous: Philippe BlainNext: Sangeeta
Message 3 of 4 in “Perf lib sanity tests fail on OSX”
  1. SangeetaDec 15, 2020
  2. Philippe BlainDec 16, 2020
  3. Eric SunshineDec 16, 2020
  4. SangeetaDec 22, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.