Re: [PATCH v2 3/4] t4203: test mailmap functionality directly rather than indirectly

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 12, 2013, 06:05 UTC
Message-ID: <CAPig+cSfqONOFmmXX=s+HWKnLr5eG27jU9xgE7Dki0sycPPz1g@mail.gmail.com>
In-Reply-To: <7v7ggwpbut.fsf@alter.siamese.dyndns.org>

On Fri, Jul 12, 2013 at 1:48 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

> Jonathan Nieder <jrnieder@gmail.com> writes:
>
>> My current thinking is "no" --- the patch has as a justification "Now
>> we can test these aspects of .mailmap handling directly with a
>> low-level tool instead of using the tool most people will use, so do
>> so", which sounds an awful lot like "Reduce test coverage of commonly
>> used tools, because we can".
>
> Yes, that was exactly my reaction that prompted my response.

Does any of my follow-up commentary result in a different reaction? If not, I'll drop patches 3 &4 in the re-roll.