Re: [PATCH 3/3] fsck: mention file path for index errors

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 29, 2023, 18:21 UTC
Message-ID: <CAPig+cSeQKr-MNN7_44wuGBCYDMm8H+1mi+X6dd-0p2DkFY2sg@mail.gmail.com>
In-Reply-To: <20230511170133.GA1977634@coredump.intra.peff.net>

On Thu, May 11, 2023 at 1:01 PM Jeff King <peff@peff.net> wrote:

Show 11 quoted lines

> On Thu, May 11, 2023 at 12:28:45PM -0400, Eric Sunshine wrote:
> > Yes, s/main/current/ probably would be helpful for future readers of
> > the code. It's unfortunate that the term "current" can ambiguously
> > also be read as meaning "the up-to-date index" or "the present-time
> > index" as opposed to "the index in this directory/worktree", which is
> > the intention here. But "current" is consistent with the existing
> > `struct worktree.is_current`, so hopefully should not be too
> > confusing.
>
> I think in this context it should be pretty clear. Do you want to
> prepare a patch?

Done. As usual, I forgot to use --in-reply-to=<this-thread> when sending the patch despite having gone through the effort of looking up the relevant message-ID of this thread. Oh well. The patch is here[1].

[1]: https://lore.kernel.org/git/20230629181333.87465-1-ericsunshine@charter.net/