Re: [PATCH] git-p4: fixed instantiation of CalledProcessError

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 6, 2022, 17:49 UTC
Message-ID: <CAPig+cSe8i9VxhJifFui0Or22fXMbD_vgy-cdRgYcA20WkGhTg@mail.gmail.com>
In-Reply-To: <20220105141427.48861-1-jholdsworth@nvidia.com>

On Thu, Jan 6, 2022 at 1:56 AM Joel Holdsworth <jholdsworth@nvidia.com> wrote:

Show 8 quoted lines

> CalledProcessError is an exception class from the subprocess namespace.
> When raising this exception, git-p4 would instantiate CalledProcessError
> objects without properly referencing the subprocess namespace causing
> the script to fail.
>
> This patch resolves the issue by replacing CalledProcessError with
> subprocess.CalledProcessError.
> ---

MIssing sign-off.