Re: [PATCH v4 1/2] compat/mingw: allow sigaction(SIGCHLD)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jul 10, 2025, 21:38 UTC
Message-ID: <CAPig+cScQN7O-cs+-9X+RpjQqJUstD10LgNYZqSHFwyAdRL+Cg@mail.gmail.com>
In-Reply-To: <f21e8ff5c9df0989ce09b3d9a50c0dc81af18837.1752176743.git.gitgitgadget@gmail.com>

On Thu, Jul 10, 2025 at 3:45 PM Carlo Marcelo Arenas Belón via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 9 quoted lines

> A future change will start using sigaction to setup a SIGCHLD signal
> handler.
>
> The current code uses signal(), which returns SIG_ERR (but doesn't
> seem to set errno) so instruct sigaction() to do the same.
>
> A new SA flag will be needed, so copy the one from Cygwinr; note that
> the sigacgtion() implementation that is provided won't use it, so
> its value is otherwise irrelevant.

s/Cygwinr/Cygwin/ s/sigacgtion/sigaction/

> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>