Re: [PATCH] send-email uses contacts to propose recipients

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 15, 2013, 22:28 UTC
Message-ID: <CAPig+cSZFU4oBuJCSXC+0Mgjegh4MzWCsDqdRYPLtwazwhy--Q@mail.gmail.com>
In-Reply-To: <1376605069-525-1-git-send-email-stefanbeller@googlemail.com>

On Thu, Aug 15, 2013 at 6:17 PM, Stefan Beller <stefanbeller@googlemail.com> wrote:

> I have got an idea regarding the send-email. If there are no recipients
> given, it could propose recipients using the new 'git contacts'
> This would help people new to projects to not forget people, who may have
> the most knowledge reviewing that specific patch.

You can already do this with git-send-email's --cc-cmd option or sendmail.cccmd configuration variable.

Show 15 quoted lines

> Unfortunately I cannot read/write perl, so I cannot solve it
> myself in the near future, but I'd put it on my todo list for later.
> ---
>  git-send-email.perl | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 2162478..a34723d 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -757,6 +757,12 @@ $sender = sanitize_address($sender);
>
>  my $prompting = 0;
>  if (!@initial_to && !defined $to_cmd) {
> +       if (git contacts is available) {

git-contacts is very slow, so at the very least you would want to prompt before invoking it.

Show 15 quoted lines

> +               proposed senders = git contacts on the same range or set of patches
> +               print "Suggesting these receivers:\n"
> +               print proposed senders
> +       }
> +
>         my $to = ask("Who should the emails be sent to (if any)? ",
>                      default => "",
>                      valid_re => qr/\@.*\./, confirm_only => 1);
> --
> 1.8.4.rc3.1.gc1ebd90
>
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html