git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] fix t3010 failure when core.ignorecase=true

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 23, 2013, 21:04 UTC
Message-ID
<CAPig+cSYPLNcMUtJTH08BAipfLOn_662k2DBwPzs2Z5dhwUhng@mail.gmail.com>
In-Reply-To
<xmqqob8onmw9.fsf@gitster.dls.corp.google.com>
On Fri, Aug 23, 2013 at 5:00 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 19 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>
>> Recent mailing list discussion [2][3] suggests that changes at a more
>> fundamental level (if they pan out) would be a more appropriate approach
>> to resolving this bug.  Such an approach would (happily) make patch 2/2
>> unnecessary, however, I'm posting this series for posterity since it was
>> already written before [2][3].
>
> Fair enough.
>
> In the meantime, given the reaction from Peff, I am tempted to
> squash your "work around in the caller side" as a fix to 2eac2a4c
> (ls-files -k: a directory only can be killed if the index has a
> non-directory, 2013-08-15) and squash in the patch to run "ls-files
> -k" with "-c core.ignorecase=true" to 3c568751 (t3010: update to
> demonstrate "ls-files -k" optimization pitfalls, 2013-08-15). That
> way, the eventual fix of not adding '/' at the end do not have to
> revert the changes to the caller, and the tests added to t3010 by
> the latter will be "optimization pitfalls" as before.
That sounds like a reasonable interim solution.
Previous: Junio C Hamano
Message 5 of 5 in “fix t3010 failure when core.ignorecase=true”
  1. 0/2 fix t3010 failure when core.ignorecase=trueEric Sunshine, Aug 23, 2013
  2. 1/2 t3103: demonstrate dir.c:treat_one_path() core.ignorecase failureEric Sunshine, Aug 23, 2013
  3. 2/2 dir: fix core.ignorecase inconsistency with missing '/'Eric Sunshine, Aug 23, 2013
  4. Junio C HamanoAug 23, 2013
  5. Eric SunshineAug 23, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.