git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rebase -i: fix rewording with --committer-date-is-author-date

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 2, 2021, 21:05 UTC
Message-ID
<CAPig+cSWDJ-zMv4zgU4oWcqXmaaCiH+03wSzQg2O=YRHthf55A@mail.gmail.com>
In-Reply-To
<pull.1123.git.git.1635883844710.gitgitgadget@gmail.com>

On Tue, Nov 2, 2021 at 4:10 PM Phillip Wood via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 10 quoted lines
> baf8ec8d3a (rebase -r: don't write .git/MERGE_MSG when
> fast-forwarding, 2021-08-20) stopped reading the author script in
> run_git_commit() when rewording a commit. This is normally safe
> because "git commit --amend" preserves the authorship. However if the
> user passes "--committer-date-is-author-date" then we need to read the
> author date from the author script when rewording. Fix this regression
> by tightening the check for when it is safe to skip reading the author
> script.
>
> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Should this have a:
    Reported-by: Jonas Kittner <jonas.kittner@ruhr-uni-bochum.de>
?
Previous: Phillip Wood via GitGitGadgetNext: Phillip Wood
Message 2 of 10 in “rebase -i: fix rewording with --committer-date-is-author-date”
  1. rebase -i: fix rewording with --committer-date-is-author-datePhillip Wood via GitGitGadget, Nov 2, 2021
  2. Eric SunshineNov 2, 2021
  3. Phillip WoodNov 2, 2021
  4. rebase -i: fix rewording with --committer-date-is-author-datePhillip Wood via GitGitGadget, Nov 2, 2021
  5. Jeff KingNov 2, 2021
  6. Phillip WoodNov 3, 2021
  7. Jeff KingNov 3, 2021
  8. Junio C HamanoNov 3, 2021
  9. Jeff KingNov 4, 2021
  10. Junio C HamanoNov 4, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.