Re: [PATCH] Makefile: avoid breaking compilation database generation with DEPELOPER

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Sep 22, 2021, 18:45 UTC
Message-ID: <CAPig+cSTiM-NWLOnSeYEhW8j5POYZ034m-cbMGdROFHp3kWXxQ@mail.gmail.com>
In-Reply-To: <20210922183311.3766-1-carenas@gmail.com>

On Wed, Sep 22, 2021 at 2:33 PM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

> Makefile: avoid breaking compilation database generation with DEPELOPER

s/DEPELOPER/DEVELOPER/

Show 9 quoted lines

> 3821c38068 (Makefile: add support for generating JSON compilation
> database, 2020-09-03), adds a feature to be used with clang to generate
> a compilation database by copying most of what was done before with the
> header dependency, but by doing so includes on its availability check
> the CFLAGS which became specially problematic once DEVELOPER=1 implied
> -pedantic as pointed out by Ævar[1].
>
> Remove the unnecessary flags in the availability test, so it will work
> regardless of which other warnings are enabled or if the compilers has

s/compilers/compiler/

Show 5 quoted lines

> been told to error on them.
>
> [1] https://lore.kernel.org/git/patch-1.1-6b2e9af5e67-20210922T103749Z-avarab@gmail.com/
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>