git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: misleading message printed when worktree add fails

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 30, 2021, 04:46 UTC
Message-ID
<CAPig+cSRonrX2SUARS=spEnWzapH6osvi3ZvZ2rPURA2zRSkvQ@mail.gmail.com>
In-Reply-To
<CAPig+cTGq-10ZTBts2LXRVdPMf2vNMX8HTuhg_+ZHSiLX-brOQ@mail.gmail.com>
On Sun, Nov 28, 2021 at 12:00 PM Eric Sunshine <sunshine@sunshineco.com> wrote:
Show 10 quoted lines
> Okay, that's happening because the "Preparing" message is sent to
> stdout, whereas the "fatal" error is sent to stderr, and the streams
> are being flushed on Windows in a different order than what we
> typically see on Unix platforms even though the "Preparing" message is
> actually output first by the code.
>
> A general fix (not specific to git-worktree) might be to have die()
> (or maybe vreportf()?) flush stdout before reporting the error message
> on stderr. That should make output order more predictable, such that
> general status messages appear before error messages.

An RFC patch has been posted to address this issue. https://lore.kernel.org/git/20211130043946.19987-1-sunshine@sunshineco.com/

Previous: rsbecker@nexbridge.com
Message 6 of 6 in “misleading message printed when worktree add fails”
  1. Baruch BursteinNov 28, 2021
  2. Eric SunshineNov 28, 2021
  3. Baruch BursteinNov 28, 2021
  4. Eric SunshineNov 28, 2021
  5. rsbecker@nexbridge.comNov 28, 2021
  6. Eric SunshineNov 30, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.