Re: [PATCH v4] daemon: add --log-destination=(stderr|syslog|none)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Feb 4, 2018, 19:36 UTC
Message-ID: <CAPig+cSOH-V9aZDALOEX56ENXChexOVWzsgKgtvDULryqP0Kyw@mail.gmail.com>
In-Reply-To: <20180204183037.23162-1-mail@lucaswerkmeister.de>

On Sun, Feb 4, 2018 at 1:30 PM, Lucas Werkmeister <mail@lucaswerkmeister.de> wrote:

Show 11 quoted lines

> This new option can be used to override the implicit --syslog of
> --inetd, or to disable all logging. (While --detach also implies
> --syslog, --log-destination=stderr with --detach is useless since
> --detach disassociates the process from the original stderr.) --syslog
> is retained as an alias for --log-destination=syslog.
> [...]
> Signed-off-by: Lucas Werkmeister <mail@lucaswerkmeister.de>
> ---
> Notes:
>     Fixes log_destination not being initialized correctly and some minor
>     style issues.

Thanks. With the 'log_destination' initialization bug fixed, this version looks good; I didn't find anything else worth commenting upon. Ævar's micronits[1] could be addressed by a follow-up patch (if desirable), but probably needn't hold up this patch.

[1]: https://public-inbox.org/git/871si0mvo0.fsf@evledraar.gmail.com/