Re: [PATCH v3] t6030: add test for git bisect skip started with --term* arguments

> Trygve Aaberge reported git bisect breakage when the bisection
> is started with --term* arguments (--term-new and --term-old).
>
> For example, suppose that we have repository with 10 commits, and we
> start the bisection from HEAD to first commit (HEAD~9) with:
>
>   $ git bisect start --term-new=fixed --term-old=unfixed HEAD HEAD~9
>
> The bisection then stopped at HEAD~5 (fifth commit), and we choose
> to skip (git bisect skip). The HEAD should now at HEAD~4 (sixth commit).
> In the breakage, however, the HEAD after skipping stayed at HEAD~5
> (not changed).
>
> The breakage is caused by forgetting to read '.git/BISECT_TERMS' during
> implementation of `'bisect skip' subcommand in C.
>
> Let's add the test to catch the breakage. Now that the corresponding
> fix had been integrated, flip the switch to test_expect_success.

> Reported-by: Trygve Aaberge <trygveaa@gmail.com>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
>
>  Changes from v2 [1]:
>    * remove double quotes inside test name
>    * double-quote HASH_SKIPPED_FROM and HASH_SKIPPED_TO in the
>      test comparison line
>    * rename test name to be simpler
>    * commit message now includes proper explanation why git bisect skip
>      is currently broken
>    * because the fix to the breakage had just been landed on seen, flip
>      the switch to test_expect_success.