Re: [PATCH v4 2/2] repo: add --all to git-repo-info

> Lucas Seiki Oshiro <lucasseikioshiro@gmail.com> writes:
> > +     if (all_keys) {
> > +             if (argc)
> > +                     die(_("--all and <key> cannot be used together"));
> > +
> > +             print_all_fields(repo, format);
> > +             return 0;
> > +     }
> >       return print_fields(argc, argv, repo, format);
>
> This would work, but the symmetry between a list of keys vs the
> "--all" option is lost.
>
> I'd rather see something like the following after a #leftoverbits
> clean-up commit:
>
>         if (all_keys && argc)
>                 die(_("--all and <key> cannot be used together"));
>
>         if (all_keys)
>                 return print_all_fields(repo, format);
>         else
>                 return print_fields(argc, argv, repo, format);