Re: [PATCH v4 1/2] cat-file: teach cat-file a '--literally' option

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 17, 2015, 06:51 UTC
Message-ID: <CAPig+cSJVGy_L6mThFCU1Bw0ZrZEv=pZ8=W8gTZd=A5y2fcR7Q@mail.gmail.com>
In-Reply-To: <1426569400-8204-1-git-send-email-karthik.188@gmail.com>

On Tue, Mar 17, 2015 at 1:16 AM, Karthik Nayak <karthik.188@gmail.com> wrote:

Show 6 quoted lines

> diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> index df99df4..1625246 100644
> --- a/builtin/cat-file.c
> +++ b/builtin/cat-file.c
> @@ -323,8 +338,8 @@ static int batch_objects(struct batch_options *opt)
>  }

I don't presently have time for a proper read-through, however, this popped out while quickly running my eyes over the changes.

Show 5 quoted lines

>  static const char * const cat_file_usage[] = {
> -       N_("git cat-file (-t | -s | -e | -p | <type> | --textconv) <object>"),
> -       N_("git cat-file (--batch | --batch-check) < <list-of-objects>"),
> +       N_("git cat-file (-t [--literally]|-s [--literally]|-e|-p|<type>|--textconv) <object>"),
> +       N_("git cat-file (--batch | --batch-check) <list-of-objects>"),

The '<' in the second line before <list-of-objects> is intentional. It means that <list-of-objects> is provided via stdin. Therefore, it is incorrect to remove it.

>         NULL
>  };
>