Re: [PATCH] grep: simplify is_empty_line

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 29, 2022, 17:06 UTC
Message-ID: <CAPig+cSFAUcU74qULYkN7OX4-OqU_3VJeTdb1ZH_QoOW9FBwZQ@mail.gmail.com>
In-Reply-To: <pull.1418.git.git.1672333122193.gitgitgadget@gmail.com>

On Thu, Dec 29, 2022 at 12:00 PM Rose via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 12 quoted lines

> diff --git a/grep.c b/grep.c
> @@ -1483,9 +1483,10 @@ static int fill_textconv_grep(struct repository *r,
>  static int is_empty_line(const char *bol, const char *eol)
>  {
> -       while (bol < eol && isspace(*bol))
> -               bol++;
> -       return bol == eol;
> +       while (bol < eol)
> +               if (!isspace(*bol))
> +                       return 0;
> +       return 1;
>  }

The rewritten code appears to be quite broken. It never increments `bol`.