Re: [PATCH] filter-branch: add passed/remaining seconds on progress
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Sep 8, 2015, 17:59 UTC
- Message-ID
- <CAPig+cS7ObsWjqbLytCKp1PGF+224TYhC734dNa_HXYQ7p+GgQ@mail.gmail.com>
- In-Reply-To
- <xmqqsi6o95r7.fsf@gitster.mtv.corp.google.com>
On Tue, Sep 8, 2015 at 1:32 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 13 quoted lines
> Eric Sunshine <sunshine@sunshineco.com> writes:
>> On Mon, Sep 7, 2015 at 9:52 AM, Gábor Bernát <bernat@primeranks.net> wrote:
>>...
>>> # Rewrite the commits
>>> +report_progress ()
>>> +{
>>> +if test -n "$progress"
>>> +then
>>
>> Indent code within the function...
>
> Also git_filter_branch__commit_count is now used only inside this
> function, so it is easier to follow to increment it here.Make sense.
Show 13 quoted lines
>>> +printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)$progress" >> >> The "\r" causes this status line to be overwritten each time through, >> and since the processed commit count always increases, we know that >> the original (without ETA) will never leave junk at the end of the >> line. However, with estimated seconds also being displayed, does this >> still hold? > > Good point. > Perhaps like this squashed in? > > -printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)$progress" > + printf "\rRewrite $commit ($git_filter_branch__commit_count/$commits)$progress "
Yes, for an expedient "fix", this is what I had in mind, although I would also have added an equal number of backspaces (\b) following the spaces, as a minor aesthetic improvement.