Re: [PATCHv2] branch.c: simplify chain of if statements

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2014, 00:44 UTC
Message-ID: <CAPig+cS2rQSAPVEN6bzSNnjFoEzf9fyBA7X7P9+cmBFOsfA1xg@mail.gmail.com>
In-Reply-To: <CAPig+cQpO+0hfqVKCzi1DwbosQ=smK=JiTPcYM8iP4r7VnSKjQ@mail.gmail.com>

On Thu, Mar 20, 2014 at 8:40 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 14 quoted lines

> On Wed, Mar 19, 2014 at 7:12 PM, Dragos Foianu <dragos.foianu@gmail.com> wrote:
>> Eric Sunshine <sunshine <at> sunshineco.com> writes:
>>> On Tue, Mar 18, 2014 at 6:31 PM, Eric Sunshine <sunshine <at>
>> sunshineco.com> wrote:
>>>
>>> One other observation: You have a one-off error in your out-of-bounds
>>> check. It should be 'index >= sizeof...'
>>
>> Well this is embarrassing.
>
> It's a good illustration of the value of the review process. It's easy
> to overlook omissions and problems in our one's work because one reads
> it with the bias of knowing what it's _supposed_ to say. Reviewers
> (hopefully) don't have such bias: they read the code afresh.

And, this is a perfect example. I knew that I wanted to say "problems in one's own work", and even though I proof-read, I still missed that I wrote "problems in our one's work".