git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v14 5/6] t7507-commit-verbose: improve test coverage by testing number of diffs

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 13, 2016, 06:03 UTC
Message-ID
<CAPig+cS17RF6f6fuTLpn-E551_NkWjmNPbXh8EFQ_Sp5L9Xb1A@mail.gmail.com>
In-Reply-To
<010201540cb6096f-5d2150af-6595-4d88-85e5-18eaeb699fb7-000000@eu-west-1.amazonses.com>
On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva <pranit.bauva@gmail.com> wrote:
Show 12 quoted lines
> Make the fake "editor" store output of grep in a file so that we can
> see how many diffs were contained in the message and use them in
> individual tests where ever it is required. A subsequent commit will
> introduce scenarios where it is important to be able to exactly
> determine how many diffs were present.
>
> Also use write_script() to create the fake "editor".
>
> The fake "editor" is always made to succeed regardless of whether grep
> found diff headers or not so that we don't have to use 'test_must_fail'
> for which 'test_line_count = 0' is an easy substitute and also helps in
> maintaining the consistency.

As mentioned by [1], the change to write_script() is a minor aside; it is less important than the explanation of how and why the return value of the fake "editor" changed, thus the order of the 2nd and 3rd paragraphs should be swapped.

[1]: http://article.gmane.org/gmane.comp.version-control.git/290663
> Helped-by: Eric Sunshine <sunshine@sunshineco.com>
> Signed-off-by: Pranit Bauva <pranit.bauva@gmail.com>
Previous: Pranit BauvaNext: Pranit Bauva
Message 21 of 22 in “t0040-test-parse-options.sh: fix style issues”
  1. 1/6 t0040-test-parse-options.sh: fix style issuesPranit Bauva, Apr 12, 2016
  2. 2/6 test-parse-options: print quiet as integerPranit Bauva, Apr 12, 2016
  3. 3/6 t0040-parse-options: improve test coveragePranit Bauva, Apr 12, 2016
  4. Eric SunshineApr 13, 2016
  5. Pranit BauvaApr 13, 2016
  6. Eric SunshineApr 13, 2016
  7. Pranit BauvaApr 25, 2016
  8. Eric SunshineApr 27, 2016
  9. Pranit BauvaApr 27, 2016
  10. 6/6 commit: add a commit.verbose config variablePranit Bauva, Apr 12, 2016
  11. Eric SunshineApr 13, 2016
  12. Pranit BauvaApr 13, 2016
  13. Eric SunshineApr 13, 2016
  14. 4/6 parse-options.c: make OPTION_COUNTUP respect "unspecified" valuesPranit Bauva, Apr 12, 2016
  15. Eric SunshineApr 13, 2016
  16. Pranit BauvaApr 13, 2016
  17. Eric SunshineApr 13, 2016
  18. Pranit BauvaApr 13, 2016
  19. Eric SunshineApr 13, 2016
  20. 5/6 t7507-commit-verbose: improve test coverage by testing number of diffsPranit Bauva, Apr 12, 2016
  21. Eric SunshineApr 13, 2016
  22. Pranit BauvaApr 13, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.