Re: [PATCH][Outreachy] branch -D: allow - as abbreviation of @{-1}

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2016, 19:26 UTC
Message-ID: <CAPig+cS-07dMStzAp+J+9_FJkREdRZcACg1CMoz_YEu9AezmJQ@mail.gmail.com>
In-Reply-To: <vpqfuvju4km.fsf@anie.imag.fr>

On Mon, Mar 21, 2016 at 1:24 PM, Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> wrote:

Show 8 quoted lines

> Elena Petrashen <elena.petrashen@gmail.com> writes:
>> * git branch (-d | -D) is not supposed to accept any other
>> arguments except for branch name so it makes sense to replace
>> the argv[i] with @{-1}. We will not lose the opportunity to
>> use it for something different for other git branch uses if
>> we will decide it’s required.
>
> This could go inside the commit message, not below the ---.

No, I think this does indeed belong here in the commentary area (below "---"); not in the commit message. The previous version of the patch incorrectly mapped "-" to "@{-1}" for all argv[], not just for the branch name, and the above paragraph is explaining that the mistake has been fixed in the current version of the patch. Whatever minor additional information the above paragraph states is already implied by the patch title and by common sense, so it probably wouldn't be helpful to bulk up the commit message just for that.