Re: [PATCH v6] commit: add a commit.verbose config variable

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 14, 2016, 21:24 UTC
Message-ID: <CAPig+cRzDbBu=wFmkUGUm58aJoz-4oecPWfbCc=4oO6geyKj5Q@mail.gmail.com>
In-Reply-To: <CAPig+cRC5kZCtELhTh3em0bv+mfeR58AKd3Y76VM+0J+C+zzcw@mail.gmail.com>

On Mon, Mar 14, 2016 at 5:21 PM, Eric Sunshine <sunshine@sunshineco.com> wrote:

Show 10 quoted lines

>> +test_expect_success 'status ignores commit.verbose=true' '
>> +       git status >actual &&
>
> This is missing the important "-c commit.verbose=false". Without it,
> you're not really testing anything interesting.
>
> (It was missing in the "something like this" example test I typed
> directly in the email of my last review[1], which I suppose is a good
> lesson that "something like this" is not meant as "final" or "trust
> this".)

That wasn't an intentional omission on my part, by the way -- I wasn't trying to mislead you -- it was just an example I typed on-the-fly without thinking too hard about it.