Re: [PATCH 2/2] t9803: update commit messages and description

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Mar 21, 2024, 19:52 UTC
Message-ID: <CAPig+cRweMree1LJ=qpOJZg7HYvgE9XX8iFvMKcAGYJpAFGFDg@mail.gmail.com>
In-Reply-To: <b8d0620d4104106210ecf6a34ada591adf01cff8.1711049963.git.gitgitgadget@gmail.com>

On Thu, Mar 21, 2024 at 3:39 PM Sanchit Jindal via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 11 quoted lines

> From: Sanchit Jindal <sanchit1053@gmail.com>
>
> replacing `test -e` with test_path_exists,
>           `test ! -e` with test_path_is_missing
>           `test -f` with test_path_is_file
> These helper functions will run the `test` command with the
> corresponding flags and will echo a message if the assert fails.
> This will provide better debugging logs for test, instead of the
> previous method which provided no message
>
> Signed-off-by: Sanchit Jindal <sanchit1053@gmail.com>

When rerolling a series to address reviewer comments, you will want the fixes applied directly to the patches about which the reviewers commented. The way to do this is to use `git rebase -i` to adjust the patches as needed. In the case of this simple series, you just want to "squash" patches [1/2] and [2/2] into a single patch using the `git rebase -i` "squash" command, and adjust the commit message of the squashed patch appropriately. Finally, to resubmit it via GitGitGadget, force-push the revised series to GitGitGadget (using `git push --force <whatever> <whatever>`), and tell GitGitGadget to "/submit".

Regarding the commit message, first explain the problem the patch is solving, and then explain how the patch solves it. Thus, start by explaining that `test` doesn't provide any diagnostic information when it fails, which isn't helpful to test authors. Then explain that the patch replaces `test` with the test_path_* functions which do provide useful diagnostic information.

The From: and Signed-off-by: lines look good in this reroll.