Re: [PATCH 9/9] subtree: fix split after annotated tag was squashed merged
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Oct 21, 2022, 18:24 UTC
- Message-ID
- <CAPig+cRszqyrPFHSaB92_kiQ60huXw2rWZbCh+JsGKetnChJUQ@mail.gmail.com>
- In-Reply-To
- <221021.86mt9pdtcw.gmgdl@evledraar.gmail.com>
On Fri, Oct 21, 2022 at 12:48 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 8 quoted lines
> On Fri, Oct 21 2022, Philippe Blain via GitGitGadget wrote:
> > +# Usage: find_existing_splits DIR REV [REPOSITORY]
> > find_existing_splits () {
> > + assert test $# = 2 -o $# = 3
>
> This "test" syntax is considered unportable, I'm too lazy to dig up the
> reference, but we've removed it in the past. Maybe it's OK with
> git-subtree.sh", but anyway, it's esay enough to change...You may be referring to POSIX[1] long considering -o/-a to be obsolescent, and GNU warning[2] against them for a couple decades or more.
[1]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/test.html#tag_20_128_16 [2]: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Limitations-of-Builtins.html