Re: What's cooking in git.git (Aug 2022, #02; Fri, 5)

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Aug 18, 2022, 19:07 UTC
Message-ID: <CAPig+cRp4N=6EktoisKAH09aVAPkPgZfHJYcB5pJFJ-CUpBHFA@mail.gmail.com>
In-Reply-To: <o5340r34-027q-4ops-93o1-8368s4qropo5@tzk.qr>

On Wed, Aug 10, 2022 at 5:26 AM Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:

Show 18 quoted lines

> On Mon, 8 Aug 2022, Junio C Hamano wrote:
> > Eric Sunshine <sunshine@sunshineco.com> writes:
> > > On Fri, Aug 5, 2022 at 11:44 PM Junio C Hamano <gitster@pobox.com> wrote:
> > >> * es/doc-creation-factor-fix (2022-07-28) 2 commits
> > >>  Expecting a reroll.
> > >
> > > Per [1] and [2], I think the intention was to drop these patches
> > > rather than moving forward with them.
> > >
> > I think we are expecting a submission by Dscho to replace these two
> > patches.
>
> Oh? I thought Eric was on top of things much more than I am, I just tried
> to provide clarity about the intentions behind the original wording.
>
> Eric, please do feel free to Cc: me on any new iteration you want to send;
> I won't be able to work on a patch to reword the `range-diff`
> documentation.

Unfortunately, I'm not going to be much help here since I don't grok "creation factor" well enough to put an explanation into words, even after having read the "algorithm" section multiple times[1]. The situation is further confused (at least to me) by the "algorithm" section in the `git range-diff` documentation stating that the "fudge factor ... should be smaller than 100%", yet your position in this discussion is that the creation factor can be greater than 100%.

FOOTNOTES

[1]: I likewise didn't understand it well enough when submitting[2] which added --creation-factor to `git format-patch`, which is why I punted at that time and simply referred the reader to the `git range-diff` documentation.

[2]: https://lore.kernel.org/git/20180722095717.17912-14-sunshine@sunshineco.com/