Re: [PATCH 3/3] blame: use changed-path Bloom filters
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 12, 2020, 07:39 UTC
- Message-ID
- <CAPig+cRm515C05SD_ivZmdPEUW=Tw3j2r4_p9_oSmRjs++BLZw@mail.gmail.com>
- In-Reply-To
- <xmqq5ze5he8o.fsf@gitster.c.googlers.com>
On Sat, Apr 11, 2020 at 6:03 PM Junio C Hamano <gitster@pobox.com> wrote:
Show 12 quoted lines
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes: > > The lack of improvement for the MAINTAINERS file and the relatively > > modest improvement for the other examples can be easily explained. > > The blame machinery needs to compute line-level diffs to determine > > which lines were changed by each commit. That makes up a large > > proportion of the computation time, and this change does not > > attempt to improve on that section of the algorithm. The > > MAINTAINERS file is large and changed often, so it takes time to > > determine which lines were updated by which commit. In contrast, > > the code files are much smaller, and it takes longer to comute > > the line-by-line diff for a single patch on the Linux mailing > > lists.
s/comute/compute/
(Sorry for replying to Junio's reply -- the original is no longer in my mailbox.)