git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t3200: refactor symlink test

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Aug 19, 2021, 05:51 UTC
Message-ID
<CAPig+cRjMYzw+Hu1wy20w8oJ-4jRmOwMB9Rt=QmNu+=8Mj7skQ@mail.gmail.com>
In-Reply-To
<20210819050103.25995-1-carenas@gmail.com>

On Thu, Aug 19, 2021 at 1:02 AM Carlo Marcelo Arenas Belón <carenas@gmail.com> wrote:

Show 25 quoted lines
> d1931bcf0d (refs: make errno output explicit for refs_resolve_ref_unsafe,
> 2021-07-20) add a test for a crash when refs is a symlink, but it fails
> on windows.
>
> add the missing SYMLINKS dependency and while at it, refactor it slightly
> to comply better with the CodingGuidelines.
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
> @@ -109,17 +109,22 @@ test_expect_success 'git branch -m n/n n should work' '
> -test_expect_success 'git branch -m with symlinked .git/refs' '
> +test_expect_success SYMLINKS 'git branch -m with symlinked .git/refs' '
>         git init subdir &&
>         test_when_finished "rm -rf subdir" &&
> -       (cd subdir &&
> -               for d in refs objects packed-refs ; do
> -               rm -rf .git/$d &&
> -               ln -s ../../.git/$d .git/$d ; done ) &&
> +       (
> +               cd subdir &&
> +               for d in refs objects packed-refs
> +               do
> +                       rm -rf .git/$d &&
> +                       ln -s ../../.git/$d .git/$d
Ideally, the above line should be:
    ln -s ../../.git/$d .git/$d || exit 1

to catch and signal a failure within the for-loop body (which happens to be in a subshell; if not in a subshell, you'd use `|| return 1`).

Show 11 quoted lines
> +               done
> +       ) &&
>         git --git-dir subdir/.git/ branch rename-src &&
> -       expect=$(git rev-parse rename-src) &&
> +       git rev-parse rename-src >expect &&
>         git --git-dir subdir/.git/ branch -m rename-src rename-dest &&
> -       test $(git rev-parse rename-dest) = "$expect" &&
> +       git rev-parse rename-dest >actual &&
> +       test_cmp expect actual &&
>         git branch -D rename-dest
>  '
Previous: Carlo Marcelo Arenas BelónNext: Carlo Marcelo Arenas Belón
Message 11 of 14 in “fixup! propagate errno from failing read”
  1. fixup! propagate errno from failing readHan-Wen Nienhuys via GitGitGadget, Aug 17, 2021
  2. Jonathan TanAug 17, 2021
  3. Jonathan NiederAug 18, 2021
  4. Junio C HamanoAug 17, 2021
  5. Han-Wen NienhuysAug 18, 2021
  6. Junio C HamanoAug 18, 2021
  7. Junio C HamanoAug 19, 2021
  8. Han-Wen NienhuysAug 19, 2021
  9. Jeff KingAug 19, 2021
  10. t3200: refactor symlink testCarlo Marcelo Arenas Belón, Aug 19, 2021
  11. Eric SunshineAug 19, 2021
  12. t3200: refactor symlink test from hn/refs-errno-cleanupCarlo Marcelo Arenas Belón, Aug 19, 2021
  13. Junio C HamanoAug 19, 2021
  14. Junio C HamanoAug 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.