Re: [PATCH] Documentation: Spelling and grammar fixes

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 22, 2018, 07:30 UTC
Message-ID: <CAPig+cRgLyjNW+7EwXZB-=xNej=FR_1dqneR8VaaHzFaYHiOBA@mail.gmail.com>
In-Reply-To: <20180622065037.27155-1-ville.skytta@iki.fi>

On Fri, Jun 22, 2018 at 2:50 AM Ville Skyttä <ville.skytta@iki.fi> wrote:

Show 7 quoted lines

> Signed-off-by: Ville Skyttä <ville.skytta@iki.fi>
> ---
> diff --git a/Documentation/config.txt b/Documentation/config.txt
> @@ -354,7 +354,7 @@ advice.*::
>         ignoredHook::
> -               Advice shown if an hook is ignored because the hook is not
> +               Advice shown if a hook is ignored because the hook is not

British vs. American English, I believe. Since the project leans toward[1] American English, this change is probably reasonable in the larger scope of this patch.

[1]: https://public-inbox.org/git/xmqq4m9gpebm.fsf@gitster.mtv.corp.google.com/

Show 6 quoted lines

> diff --git a/Documentation/technical/api-gitattributes.txt b/Documentation/technical/api-gitattributes.txt
> @@ -146,7 +146,7 @@ To get the values of all attributes associated with a file:
>  * Iterate over the `attr_check.items[]` array to examine
>    the attribute names and values.  The name of the attribute
> -  described by a  `attr_check.items[]` object can be retrieved via
> +  described by an `attr_check.items[]` object can be retrieved via

This also collapses the space-space to a single space, which is good.

All the other changes look fine, as well. Thanks.