git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] commit: disable status hints when writing to COMMIT_EDITMSG

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Sep 11, 2013, 09:13 UTC
Message-ID
<CAPig+cRfgSrSMHT0OX0H=uh-Wi3TceU+UN8gUH4La1RTpRLETQ@mail.gmail.com>
In-Reply-To
<1378890539-1966-2-git-send-email-Matthieu.Moy@imag.fr>
On Wed, Sep 11, 2013 at 5:08 AM, Matthieu Moy <Matthieu.Moy@imag.fr> wrote:
Show 6 quoted lines
> Most status hints were written to be accurate when running "git status"
> before running a commit. Many of them are not applicable when the commit
> has already been started, and should not be shown in COMMIT_EDITMSG. The
> most obvious are hints advising to run "git commit",
> "git rebase/am/cherry-pick --continue", which do not make sense when the
> command has already been ran.
s/ran/run/
> Other messages become slightly inaccurate (e.g. hint to use "git add" to
> add untracked files), as the suggested commands are not immediately
> applicable during the edition of COMMIT_EDITMSG, but would be applicable
s/edition/editing/
Show 5 quoted lines
> if the commit is aborted. These messages are both potentially helpful and
> slightly misleading. This patch chose to remove them too, to avoid
> introducing too much complexity in the status code.
>
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Previous: Matthieu MoyNext: Jeff King
Message 3 of 6 in “wt-status: turn advice_status_hints into a field of wt_status”
  1. 1/2 wt-status: turn advice_status_hints into a field of wt_statusMatthieu Moy, Sep 11, 2013
  2. 2/2 commit: disable status hints when writing to COMMIT_EDITMSGMatthieu Moy, Sep 11, 2013
  3. Eric SunshineSep 11, 2013
  4. Jeff KingSep 11, 2013
  5. Matthieu MoySep 12, 2013
  6. Jeff KingSep 12, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.