git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: chainlink.pl /proc/cpuinfo regexp fails on s390x

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Nov 22, 2022, 23:50 UTC
Message-ID
<CAPig+cRchF_6t-B-cZHLHAH_E6qNmapTezSfCj9AZ8cfWNzivw@mail.gmail.com>
In-Reply-To
<87v8n6o9du.fsf@igel.home>
On Tue, Nov 22, 2022 at 6:37 PM Andreas Schwab <schwab@linux-m68k.org> wrote:
Show 7 quoted lines
> On Nov 22 2022, Andreas Hasenack wrote:
> > /^processor[\s\d]*:/
> > or something else.
>
> Something else.
>
> $ getconf _NPROCESSORS_ONLN

Yes, that works too and was (I'm pretty sure) considered during development. The reason /proc/cpu was chosen over `getconf` was that opening & reading /proc/cpu should be faster since it doesn't involve spawning a process. If we did use `getconf`, we'd have to be careful to degrade gracefully if `getconf` isn't available or if the configuration parameter (i.e. "_NPROCESSORS_ONLN") isn't known on the platform.

That said, the submitted patch[1] is probably good enough for now, especially since there's talk about possibly removing this code entirely.

[1]: https://lore.kernel.org/git/pull.1385.git.git.1669148861635.gitgitgadget@gmail.com/
Previous: Andreas SchwabNext: Andreas Schwab
Message 8 of 10 in “chainlink.pl /proc/cpuinfo regexp fails on s390x”
  1. Andreas HasenackNov 22, 2022
  2. Eric SunshineNov 22, 2022
  3. Andreas HasenackNov 22, 2022
  4. Eric SunshineNov 22, 2022
  5. Andreas HasenackNov 22, 2022
  6. Eric SunshineNov 22, 2022
  7. Andreas SchwabNov 22, 2022
  8. Eric SunshineNov 22, 2022
  9. Andreas SchwabNov 23, 2022
  10. Eric SunshineNov 23, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.