git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t0060: loosen overly strict expectations

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Jan 14, 2016, 18:52 UTC
Message-ID
<CAPig+cRa9mk0U4iPim5GRWzFN-vHEA=rx8bb40oQyCJVZL7t3A@mail.gmail.com>
In-Reply-To
<eccf149d9557fd9afb591d9411ecb0b3460c9eb0.1452754049.git.johannes.schindelin@gmx.de>

On Thu, Jan 14, 2016 at 1:48 AM, Johannes Schindelin <johannes.schindelin@gmx.de> wrote:

Show 19 quoted lines
> The dirname() tests file were developed and tested on only the five
> platforms available to the developer at the time, namely: Linux (both 32
> and 64bit), Windows XP 32-bit (MSVC), MinGW 32-bit and Cygwin 32-bit.
>
> http://pubs.opengroup.org/onlinepubs/9699919799/functions/basename.html
> (i.e. the POSIX spec) says, in part:
>
>         If the string pointed to by path consists entirely of the '/'
>         character, basename() shall return a pointer to the string "/".
>         If the string pointed to by path is exactly "//", it is
>         implementation-defined whether "/" or "//" is returned.
>
> The thinking behind testing precise, OS-dependent output values was to
> document that different setups produce different values. However, as the
> test failures on MacOSX illustrated eloquently: hardcoding pretty much each
> and every setup's expectations is pretty fragile.
>
> This is not limited to the "//" vs "/" case, of course, other inputs are
> also allowed to produce multiple outpus by the POSIX specs.
s/outpus/outputs/
Show 5 quoted lines
> So let's just test for all allowed values and be done with it. This still
> documents that Git cannot rely on one particular output value in those
> cases, so the intention of the original tests is still met.
>
> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Previous: Ramsay JonesNext: Johannes Schindelin
Message 10 of 13 in “t0060: loosen overly strict expectations”
  1. t0060: loosen overly strict expectationsJohannes Schindelin, Jan 14, 2016
  2. Junio C HamanoJan 14, 2016
  3. Ramsay JonesJan 14, 2016
  4. Johannes SixtJan 14, 2016
  5. Ramsay JonesJan 15, 2016
  6. Johannes SchindelinJan 15, 2016
  7. Ramsay JonesJan 15, 2016
  8. Johannes SixtJan 15, 2016
  9. Ramsay JonesJan 15, 2016
  10. Eric SunshineJan 14, 2016
  11. Johannes SchindelinJan 15, 2016
  12. Junio C HamanoJan 15, 2016
  13. Johannes SchindelinJan 19, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.