Re: [PATCH] fetch: add new config option fetch.all

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jan 4, 2024, 20:55 UTC
Message-ID: <CAPig+cRYmPj6s0SHHnG5GYaDGE7t-2qADB+VD4PMec39YHoaRQ@mail.gmail.com>
In-Reply-To: <20240104202605.7382-1-dev@tb6.eu>

On Thu, Jan 4, 2024 at 3:26 PM Tamino Bauknecht <dev@tb6.eu> wrote:

Show 11 quoted lines

> diff --git a/t/t5514-fetch-multiple.sh b/t/t5514-fetch-multiple.sh
> @@ -24,6 +24,15 @@ setup_repository () {
> +test_expect_success 'git fetch (fetch all remotes with fetch.all = true)' '
> +       setup_test_clone test9 && (
> +        cd test9 &&
> +        git config fetch.all true &&
> +        git fetch --all &&
> +        git branch -r >actual &&
> +        cp ../test_fetch_all_true/expect . &&
> +        test_cmp expect actual)
> +'

I forgot to mention that the formatting and subsequent indentation of the subshell is a bit unusual and out of line with project style. We normally format subshells like this:

    setup_test_clone test9 &&
    (
        cd test9 &&
        ...
    )

where the code outside the shell is indented by one TAB, and the code inside the subshell indented by two TABs.

That differs from what is in your patch, in which the code inside the subshell is indented by a TAB followed by a space.