Re: [PATCH 3/3] odb: properly close sources before freeing them

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Dec 5, 2025, 23:14 UTC
Message-ID: <CAPig+cRW6tXFTqqnhH1Be33TgzT2dsdzNLFii3Now7+DNiTTvw@mail.gmail.com>
In-Reply-To: <20251205-odb-related-fixes-v1-3-ef4250abb584@pks.im>

On Fri, Dec 5, 2025 at 6:36 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 6 quoted lines

> In the next commit we are about to move the packfile store into the ODB
> source so that we have one store per source. This will lead to a memory
> leak in the following commit when reading data from a submodule via
> git-grep(1):
> [...]
> Signed-off-by: Patrick Steinhardt <ps@pks.im>

Considering that this is patch [3/3], to what does "In the next commit..." refer?

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.